Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for disabling features in ImageTool #269

Merged
merged 7 commits into from
Oct 29, 2024

Conversation

idebenone
Copy link
Member

@idebenone idebenone commented Sep 30, 2024

Problem:

Users were unable to configure which image tunes (e.g., caption, border, background) should be available in the ImageTool.

Solution:

Implemented a mechanism that allows users to specify which tunes should be available via configuration. If no specific tunes are provided, all default tunes will be available.

closes #29 , closes #236

@idebenone idebenone requested a review from neSpecc September 30, 2024 18:11
README.md Outdated Show resolved Hide resolved
dev/index.html Outdated Show resolved Hide resolved
dev/index.html Outdated Show resolved Hide resolved
src/index.ts Show resolved Hide resolved
src/index.ts Show resolved Hide resolved
@idebenone idebenone requested a review from neSpecc October 3, 2024 11:58
@idebenone
Copy link
Member Author

idebenone commented Oct 3, 2024

@neSpecc

Summary

  • removed caption from tunes.
  • changed the config.features type from array to an object.
  • renamed CSS classes eliminating prefix with for border and background, which aligns with variable names user defines through config.features .

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
src/types/types.ts Outdated Show resolved Hide resolved
src/types/types.ts Outdated Show resolved Hide resolved
src/types/types.ts Outdated Show resolved Hide resolved
@idebenone idebenone requested a review from neSpecc October 10, 2024 16:35
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
src/index.ts Show resolved Hide resolved
src/types/types.ts Outdated Show resolved Hide resolved
src/types/types.ts Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
src/types/types.ts Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
src/types/types.ts Outdated Show resolved Hide resolved
@idebenone idebenone merged commit b97f7d1 into master Oct 29, 2024
1 check passed
@idebenone idebenone changed the title Support for selecting and enabling specific tunes in ImageTool Support for disabling features in ImageTool Oct 29, 2024
@idebenone idebenone deleted the feature/enable-tune-selection branch November 30, 2024 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants